Skip to content

Remove unused program param from isArrayModelType and isRecordModelType #9336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FionaBronwen wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Remove unused program param from isArrayModelType and isRecordModelType #9336

FionaBronwen wants to merge 7 commits into from

Conversation

@FionaBronwen
Copy link
Contributor

@FionaBronwen FionaBronwen commented Jan 12, 2026 •
edited
Loading

Summary

Added overloads to isArrayModelType and isRecordModelType that don't require the unused program parameter. The old signature is deprecated but still works for backward compatibility.

Usage

// New (preferred)
isArrayModelType(type)
isRecordModelType(type)

// Old (deprecated, still works)
isArrayModelType(program, type)
isRecordModelType(program, type)

@microsoft-github-policy-service microsoft-github-policy-service bot added compiler:core Issues for @typespec/compiler lib:http tspd Issues for the tspd tool emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:openapi3 Issues for @typespec/openapi3 emitter labels Jan 12, 2026
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 12, 2026 •
edited
Loading

Open in StackBlitz

@typespec/compiler

npm i https://pkg.pr.new/microsoft/typespec/@typespec/compiler@9336

@typespec/http

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http@9336

@typespec/http-server-csharp

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-server-csharp@9336

@typespec/http-server-js

npm i https://pkg.pr.new/microsoft/typespec/@typespec/http-server-js@9336

@typespec/openapi

npm i https://pkg.pr.new/microsoft/typespec/@typespec/openapi@9336

@typespec/openapi3

npm i https://pkg.pr.new/microsoft/typespec/@typespec/openapi3@9336

@typespec/tspd

npm i https://pkg.pr.new/microsoft/typespec/@typespec/tspd@9336

commit: fc8a1a6

@github-actions
Copy link
Contributor

github-actions bot commented Jan 12, 2026 •
edited
Loading

All changed packages have been documented.

  • ✅ @typespec/compiler
  • ✅ @typespec/http-server-csharp
  • ✅ @typespec/http-server-js
  • ✅ @typespec/http
  • ✅ @typespec/openapi3
  • ✅ @typespec/tspd
Show changes

@typespec/compiler - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@typespec/http - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@typespec/openapi3 - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@typespec/tspd - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@typespec/http-server-js - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@typespec/http-server-csharp - deprecation ✏️

Deprecate program parameter in isArrayModelType and isRecordModelType functions. Use the new single-argument overload instead: isArrayModelType(type) and isRecordModelType(type).

@FionaBronwen FionaBronwen force-pushed the fionabronwen/type-utils branch 2 times, most recently from e2c2b45 to d708f88 Compare January 13, 2026 16:00
@FionaBronwen FionaBronwen force-pushed the fionabronwen/type-utils branch from d708f88 to 559cd74 Compare January 13, 2026 17:34
@FionaBronwen FionaBronwen mentioned this pull request Jan 13, 2026
Merged
@FionaBronwen FionaBronwen marked this pull request as ready for review January 13, 2026 20:46
@FionaBronwen FionaBronwen marked this pull request as draft January 15, 2026 16:20
@FionaBronwen FionaBronwen marked this pull request as ready for review January 16, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@witemple-msft witemple-msft Awaiting requested review from witemple-msft witemple-msft is a code owner

@chrisradek chrisradek Awaiting requested review from chrisradek chrisradek is a code owner

@AlitzelMendez AlitzelMendez Awaiting requested review from AlitzelMendez AlitzelMendez is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

compiler:core Issues for @typespec/compiler emitter:client:java Issue for the Java client emitter: @typespec/http-client-java emitter:openapi3 Issues for @typespec/openapi3 emitter lib:http tspd Issues for the tspd tool

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@FionaBronwen